From 396e82d7a642f2c57d718b2f2e1a614e4a6ad2aa Mon Sep 17 00:00:00 2001
From: Pierre <pierre@hubert.fr>
Date: Sun, 25 Mar 2018 09:11:59 +0200
Subject: [PATCH] Made comments actions button smaller.

---
 .../comunic/client/ui/adapters/CommentsAdapter.java      | 2 +-
 app/src/main/res/layout/comment_item.xml                 | 9 +++++----
 app/src/main/res/values/dimens.xml                       | 6 +++++-
 app/src/main/res/values/strings.xml                      | 1 +
 app/src/main/res/values/styles.xml                       | 1 +
 5 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/app/src/main/java/org/communiquons/android/comunic/client/ui/adapters/CommentsAdapter.java b/app/src/main/java/org/communiquons/android/comunic/client/ui/adapters/CommentsAdapter.java
index c2ae879..112bde0 100644
--- a/app/src/main/java/org/communiquons/android/comunic/client/ui/adapters/CommentsAdapter.java
+++ b/app/src/main/java/org/communiquons/android/comunic/client/ui/adapters/CommentsAdapter.java
@@ -93,7 +93,7 @@ class CommentsAdapter extends ArrayAdapter<Comment> {
         ((TextView) view.findViewById(R.id.comment_text)).setText(comment.getContent());
 
         //Update comment actions
-        ImageButton actions = view.findViewById(R.id.comment_actions_btn);
+        ImageView actions = view.findViewById(R.id.comment_actions_btn);
 
         actions.setOnClickListener(new View.OnClickListener() {
             @Override
diff --git a/app/src/main/res/layout/comment_item.xml b/app/src/main/res/layout/comment_item.xml
index 9c23b7d..1aadd3d 100644
--- a/app/src/main/res/layout/comment_item.xml
+++ b/app/src/main/res/layout/comment_item.xml
@@ -33,11 +33,12 @@
         tools:text="A comment content" />
 
     <!-- Comment actions -->
-    <ImageButton
+    <ImageView
         style="@style/CommentActionsButton"
         android:id="@+id/comment_actions_btn"
-        android:layout_width="wrap_content"
-        android:layout_height="wrap_content"
-        android:src="@android:drawable/ic_menu_manage" />
+        android:layout_width="@dimen/comment_options_btn_width"
+        android:layout_height="@dimen/comment_options_btn_height"
+        android:src="@android:drawable/ic_menu_manage"
+        android:contentDescription="@string/comment_action_btn_description"/>
 
 </LinearLayout>
\ No newline at end of file
diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
index bb77c3a..fd9cfc1 100644
--- a/app/src/main/res/values/dimens.xml
+++ b/app/src/main/res/values/dimens.xml
@@ -11,7 +11,11 @@
     <dimen name="fragment_conversations_list_icon_width">20dp</dimen>
     <dimen name="fragment_conversations_list_icon_height">20dp</dimen>
 
-    <!-- Dimension for the conversation fragment -->
+    <!-- Dimensions for the conversation fragment -->
     <dimen name="fragment_conversation_buttons_height">50dp</dimen>
     <dimen name="fragment_conversation_buttons_width">50dp</dimen>
+
+    <!-- Dimensions for the comments options button -->
+    <dimen name="comment_options_btn_width">20dp</dimen>
+    <dimen name="comment_options_btn_height">20dp</dimen>
 </resources>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 0857a68..4f3a01c 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -111,4 +111,5 @@
     <string name="popup_deletecomment_cancel">No</string>
     <string name="popup_deletecomment_confirm">Yes</string>
     <string name="err_delete_comment">An error occurred while trying to delete the comment !</string>
+    <string name="comment_action_btn_description">Actions on comment</string>
 </resources>
diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml
index 077561a..9cec9b0 100644
--- a/app/src/main/res/values/styles.xml
+++ b/app/src/main/res/values/styles.xml
@@ -96,5 +96,6 @@
     <!-- Comment actions button -->
     <style name="CommentActionsButton">
         <item name="android:padding">2dp</item>
+        <item name="android:layout_gravity">center</item>
     </style>
 </resources>