Comunic/ComunicAndroid
1
0
Fork 0
mirror of https://github.com/pierre42100/ComunicAndroid synced 2024-11-27 07:49:28 +00:00
Code Issues Projects Releases Wiki Activity

Improved SinglePostFragment

Browse Source
This commit is contained in:
Pierre HUBERT 2018-08-31 11:54:58 +02:00
parent 9d7f811872
commit cf763ccb18
2 changed files with 73 additions and 58 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
app/src/main/java/org/communiquons/android/comunic/client/ui/asynctasks/GetSinglePostTask.java Normal file
View File

@ -0,0 +1,35 @@
package org.communiquons.android.comunic.client.ui.asynctasks;
import android.content.Context;
import org.communiquons.android.comunic.client.data.arrays.PostsList;
import org.communiquons.android.comunic.client.data.asynctasks.SafeAsyncTask;
import org.communiquons.android.comunic.client.data.helpers.GetUsersHelper;
import org.communiquons.android.comunic.client.data.helpers.PostsHelper;
import org.communiquons.android.comunic.client.data.models.Post;
/**
* Get single post async task
*
* @author Pierre HUBERT
*/
public class GetSinglePostTask extends SafeAsyncTask<Integer, Void, PostsList> {
public GetSinglePostTask(Context context) {
super(context);
}
@Override
protected PostsList doInBackground(Integer... integers) {
Post post = new PostsHelper(getContext()).getSingle(integers[0]);
if(post == null) return null;
PostsList list = new PostsList();
list.add(post);
list.setUsersInfo(new GetUsersHelper(getContext()).getMultiple(list.getUsersId()));
return list;
}
}

96
app/src/main/java/org/communiquons/android/comunic/client/ui/fragments/SinglePostFragment.java
View File

@ -6,7 +6,6 @@ import android.support.annotation.NonNull;
import android.support.annotation.Nullable; import android.support.annotation.Nullable;
import android.support.v4.app.Fragment; import android.support.v4.app.Fragment;
import android.support.v4.app.FragmentTransaction; import android.support.v4.app.FragmentTransaction;
import android.util.ArrayMap;
import android.view.LayoutInflater; import android.view.LayoutInflater;
import android.view.View; import android.view.View;
import android.view.ViewGroup; import android.view.ViewGroup;
@ -14,10 +13,8 @@ import android.widget.Toast;
import org.communiquons.android.comunic.client.R; import org.communiquons.android.comunic.client.R;
import org.communiquons.android.comunic.client.data.arrays.PostsList; import org.communiquons.android.comunic.client.data.arrays.PostsList;
import org.communiquons.android.comunic.client.data.helpers.GetUsersHelper; import org.communiquons.android.comunic.client.data.asynctasks.SafeAsyncTask;
import org.communiquons.android.comunic.client.data.helpers.PostsHelper; import org.communiquons.android.comunic.client.ui.asynctasks.GetSinglePostTask;
import org.communiquons.android.comunic.client.data.models.Post;
import org.communiquons.android.comunic.client.data.models.UserInfo;
/** /**
* Single post fragment * Single post fragment
@ -40,30 +37,15 @@ public class SinglePostFragment extends Fragment {
*/ */
private int mPostID = 0; private int mPostID = 0;
/**
* Information about the post
*/
private Post mPost;
/** /**
* Post list that contains only a single post * Post list that contains only a single post
*/ */
private PostsList mPostsList; private PostsList mPostsList;
/** /**
* Information about the related users * Get single post task
*/ */
private ArrayMap<Integer, UserInfo> mUserInfo; private GetSinglePostTask mGetSinglePostTask;
/**
* Post helper
*/
private PostsHelper mPostsHelper;
/**
* Get user information helper
*/
private GetUsersHelper mGetUserHelper;
@Override @Override
public void onCreate(@Nullable Bundle savedInstanceState) { public void onCreate(@Nullable Bundle savedInstanceState) {
@ -72,11 +54,6 @@ public class SinglePostFragment extends Fragment {
//Get post ID //Get post ID
mPostID = getArguments().getInt(ARGUMENT_POST_ID); mPostID = getArguments().getInt(ARGUMENT_POST_ID);
//Create post helper
mPostsHelper = new PostsHelper(getActivity());
//Create get user helper
mGetUserHelper = new GetUsersHelper(getActivity());
} }
@Nullable @Nullable
@ -90,11 +67,22 @@ public class SinglePostFragment extends Fragment {
super.onResume(); super.onResume();
//Check if the fragment contains information about the post //Check if the fragment contains information about the post
if(mPost == null || mUserInfo == null){ if(mPostsList == null){
getPostInfo(); getPostInfo();
} }
else else
onGotPostInfo(); show_posts();
}
@Override
public void onStop() {
super.onStop();
unset_all_tasks();
}
public void unset_all_tasks(){
if(mGetSinglePostTask != null)
mGetSinglePostTask.setOnPostExecuteListener(null);
} }
/** /**
@ -103,53 +91,45 @@ public class SinglePostFragment extends Fragment {
private void getPostInfo(){ private void getPostInfo(){
//Perform the request in the background //Perform the request in the background
new AsyncTask<Integer, Void, Void>(){ unset_all_tasks();
mGetSinglePostTask = new GetSinglePostTask(getActivity());
mGetSinglePostTask.setOnPostExecuteListener(new SafeAsyncTask.OnPostExecuteListener<PostsList>() {
@Override @Override
protected Void doInBackground(Integer... params) { public void OnPostExecute(PostsList posts) {
onGotPostInfo(posts);
//Intend to get information about the post
mPost = mPostsHelper.getSingle(params[0]);
if(mPost != null) {
mPostsList = new PostsList();
mPostsList.add(mPost);
mUserInfo = mGetUserHelper.getMultiple(mPostsList.getUsersId());
mPostsList.setUsersInfo(mUserInfo);
}
return null;
} }
});
@Override mGetSinglePostTask.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR, mPostID);
protected void onPostExecute(Void aVoid) {
if(getActivity() == null)
return;
onGotPostInfo();
}
}.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR, mPostID);
} }
/** /**
* This method is triggered once we got informations about the post * This method is triggered once we got information about the post
*/ */
private void onGotPostInfo(){ private void onGotPostInfo(@Nullable PostsList list) {
//Check if we did not get post information //Check if we did not get post information
if(mPost == null){ if (list == null) {
Toast.makeText(getActivity(), R.string.err_get_post_info, Toast.LENGTH_SHORT).show(); Toast.makeText(getActivity(), R.string.err_get_post_info, Toast.LENGTH_SHORT).show();
return; return;
} }
//Check if we could not get user information //Check if we could not get user information
if(mUserInfo == null){ if (!list.hasUsersInfo()) {
Toast.makeText(getActivity(), R.string.err_get_users_info, Toast.LENGTH_SHORT).show(); Toast.makeText(getActivity(), R.string.err_get_users_info, Toast.LENGTH_SHORT).show();
return; return;
} }
mPostsList = list;
show_posts();
}
/**
* Show the list of posts
*/
private void show_posts(){
//Apply the post fragment //Apply the post fragment
PostsListFragment postsListFragment = new PostsListFragment(); PostsListFragment postsListFragment = new PostsListFragment();
postsListFragment.setPostsList(mPostsList); postsListFragment.setPostsList(mPostsList);