Comunic/comunicapiv2
1
0
Fork 0
mirror of https://gitlab.com/comunic/comunicapiv2 synced 2024-11-22 13:29:22 +00:00
Code Issues Projects Releases Wiki Activity

Use Set instead of Array for conversation members

Browse Source
This commit is contained in:
Pierre HUBERT 2019-11-30 14:41:34 +01:00
parent 862d8e0210
commit abd6514b59
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/controllers/ConversationsController.ts
View File

@ -21,7 +21,7 @@ export class ConversationsController {
const name = h.postString("name"); const name = h.postString("name");
const members = [...new Set(h.postNumbersList("users"))]; const members = h.postNumbersSet("users");
// Check if the users exists // Check if the users exists
for (const userID of members) { for (const userID of members) {
@ -29,8 +29,8 @@ export class ConversationsController {
h.error(404, "User " + userID + " not found!"); h.error(404, "User " + userID + " not found!");
} }
if(!members.includes(h.getUserId())) if(!members.has(h.getUserId()))
members.push(h.getUserId()); members.add(h.getUserId());
const conv : BaseConversation = { const conv : BaseConversation = {
ownerID: h.getUserId(), ownerID: h.getUserId(),
@ -149,7 +149,7 @@ export class ConversationsController {
name: c.name.length > 0 ? c.name : false, name: c.name.length > 0 ? c.name : false,
following: c.following ? 1 : 0, following: c.following ? 1 : 0,
saw_last_message: c.sawLastMessage ? 1 : 0, saw_last_message: c.sawLastMessage ? 1 : 0,
members: c.members members: [...c.members]
}; };
} }
} }

2
src/entities/Conversation.ts
View File

@ -8,7 +8,7 @@ export interface BaseConversation {
ownerID: number, ownerID: number,
name: string, name: string,
following: boolean, following: boolean,
members: Array<number> members: Set<number>
} }
export interface Conversation extends BaseConversation { export interface Conversation extends BaseConversation {

2
src/helpers/ConversationsHelper.ts
View File

@ -271,7 +271,7 @@ export class ConversationsHelper {
timeCreate: row.time_add, timeCreate: row.time_add,
following: row.following, following: row.following,
sawLastMessage: row.saw_last_message == 1, sawLastMessage: row.saw_last_message == 1,
members: [...await this.GetConversationMembers(row.id)] members: await this.GetConversationMembers(row.id)
} }
} }
} }