Fix a few notices

lib/forez/tour/join_group_pane.dart

@@ -36,8 +36,7 @@ class _JoinGroupPaneBody extends StatefulWidget {
   const _JoinGroupPaneBody({
     Key? key,
     required this.onUpdated,
-  })  : assert(onUpdated != null),
+  })  : super(key: key);
-        super(key: key);
 
   @override
   JoinGroupPaneBodyState createState() => JoinGroupPaneBodyState();

lib/forez/ui/routes/forez_member_profile_route.dart

@@ -26,8 +26,7 @@ class ForezMemberProfileRoute extends StatefulWidget {
   const ForezMemberProfileRoute({
     Key? key,
     required this.userID,
-  })  : assert(userID != null),
+  }) : super(key: key);
-        super(key: key);
 
   @override
   _ForezMemberProfileRouteState createState() =>

lib/forez/ui/routes/forez_route.dart

@@ -210,7 +210,5 @@ class _Tab {
     required this.title,
     required this.widget,
     this.isUnread,
-  })  : assert(icon != null),
+  });
-        assert(title != null),
-        assert(widget != null);
 }

lib/forez/ui/routes/search_users.dart

@@ -15,7 +15,7 @@ Future<User?> searchUser(BuildContext context, UsersList users) async {
 class _SearchDelegate extends SearchDelegate<User?> {
   final UsersList _usersList;
 
-  _SearchDelegate(this._usersList) : assert(_usersList != null);
+  _SearchDelegate(this._usersList);
 
   @override
   List<Widget>? buildActions(BuildContext context) => null;

lib/forez/ui/screens/forez_directory_screen.dart

@@ -207,12 +207,7 @@ class _MembershipButton extends StatelessWidget {
     required this.onTap,
     required this.color,
     required this.icon,
-  })  : assert(user != null),
+  }) : super(key: key);
-        assert(action != null),
-        assert(onTap != null),
-        assert(color != null),
-        assert(icon != null),
-        super(key: key);
 
   @override
   Widget build(BuildContext context) => ElevatedButton(

lib/helpers/events_helper.dart

@@ -122,9 +122,7 @@ class NewCallSignalEvent {
     required this.peerID,
     this.sessionDescription,
     this.candidate,
-  })  : assert(callID != null),
+  }) : assert(sessionDescription != null || candidate != null);
-        assert(peerID != null),
-        assert(sessionDescription != null || candidate != null);
 }
 
 /// Call peer ready event

lib/helpers/groups_helper.dart

@@ -51,7 +51,7 @@ class GetAdvancedInfoResult {
   final GetAdvancedInfoStatus status;
   final AdvancedGroupInfo? info;
 
-  GetAdvancedInfoResult(this.status, this.info) : assert(status != null);
+  GetAdvancedInfoResult(this.status, this.info);
 }
 
 /// Groups helper

lib/helpers/serialization/conversation_message_serialization_helper.dart

@@ -15,8 +15,7 @@ class ConversationsMessagesSerializationHelper
   final int convID;
 
   ConversationsMessagesSerializationHelper._(int convID)
-      : convID = convID,
+      : convID = convID;
-        assert(convID != null);
 
   factory ConversationsMessagesSerializationHelper(int? convID) {
     if (_instances == null) _instances = HashMap();

lib/helpers/survey_helper.dart

@@ -26,8 +26,6 @@ class SurveyHelper {
   /// Send the response of a user to a survey
   Future<bool> respondToSurvey(
       {required Survey survey, required SurveyChoice choice}) async {
-    assert(survey != null);
-    assert(choice != null);
 
     return (await APIRequest(
       uri: "surveys/send_response",

lib/helpers/virtual_directory_helper.dart

@@ -13,7 +13,7 @@ class VirtualDirectoryResult {
   const VirtualDirectoryResult({
     required this.type,
     this.id,
-  }) : assert(type != null);
+  });
 }
 
 class VirtualDirectoryHelper {

lib/models/advanced_group_info.dart

@@ -37,8 +37,7 @@ class AdvancedGroupInfo extends Group implements LikeElement {
     required this.userLike,
     required this.conversations,
     required this.isForezGroup,
-  })  : assert(isForezGroup != null),
+  }) : super(
-        super(
             id: id,
             name: name,
             iconURL: iconURL,
@@ -53,8 +52,7 @@ class AdvancedGroupInfo extends Group implements LikeElement {
   @override
   LikesType likeType = LikesType.GROUP;
 
-  get hasURL => url != null && url.isNotEmpty && url != "null";
+  get hasURL => url.isNotEmpty && url != "null";
 
-  get hasDescription =>
+  get hasDescription => description.isNotEmpty && description != "null";
-      description != null && description.isNotEmpty && description != "null";
 }

lib/models/api_request.dart

@@ -32,21 +32,15 @@ class APIRequest {
   Map<String, File> files = Map();
   Map<String, BytesFile?> bytesFiles = Map();
 
-  APIRequest({required this.uri, this.needLogin = false, this.args})
+  APIRequest({required this.uri, this.needLogin = false, this.args}) {
-      : assert(uri != null),
-        assert(needLogin != null) {
     if (this.args == null) this.args = Map();
   }
 
-  APIRequest.withLogin(this.uri, {this.args})
+  APIRequest.withLogin(this.uri, {this.args}) : needLogin = true {
-      : needLogin = true,
-        assert(uri != null) {
     if (args == null) this.args = Map();
   }
 
-  APIRequest.withoutLogin(this.uri, {this.args})
+  APIRequest.withoutLogin(this.uri, {this.args}) : needLogin = false {
-      : needLogin = false,
-        assert(uri != null) {
     if (args == null) this.args = Map();
   }
 

lib/models/call_config.dart

@@ -1,5 +1,3 @@
-
-
 /// Call configuration
 ///
 /// @author Pierre Hubert
@@ -9,7 +7,7 @@ class CallConfig {
 
   const CallConfig({
     required this.iceServers,
-  }) : assert(iceServers != null);
+  });
 
   /// Turn this call configuration into the right for the WebRTC plugin
   Map<String, dynamic> get pluginConfig => {

lib/models/conversation_message.dart

@@ -112,8 +112,7 @@ class ConversationServerMessage {
     required this.userAdded,
     required this.userWhoRemoved,
     required this.userRemoved,
-  })  : assert(type != null),
+  })  : assert(userID != null ||
-        assert(userID != null ||
             (type != ConversationServerMessageType.USER_CREATED_CONVERSATION &&
                 type != ConversationServerMessageType.USER_LEFT_CONV)),
         assert((userWhoAdded != null && userAdded != null) ||

lib/models/survey.dart

@@ -24,17 +24,9 @@ class Survey {
     required this.userChoice,
     required this.choices,
     required this.allowNewChoicesCreation,
-  })  : assert(id != null),
+  }) : assert(choices.length > 0);
-        assert(userID != null),
-        assert(postID != null),
-        assert(creationTime != null),
-        assert(question != null),
-        assert(userChoice != null),
-        assert(choices != null),
-        assert(choices.length > 0),
-        assert(allowNewChoicesCreation != null);
 
-  bool get hasResponded => this.userChoice != null && this.userChoice > 0;
+  bool get hasResponded => this.userChoice > 0;
 
   bool get hasResponses =>
       this.choices.where((f) => f.responses > 0).length > 0;