pierre/MoneyMgr
1
0
Fork 0
Code Issues Pull Requests 4 Actions Packages Projects Releases 4 Wiki Activity

Fix indempotent updates

Browse Source
This commit is contained in:
Pierre HUBERT
2025-04-19 22:23:07 +02:00
parent 2a1b1ea45a
commit f5b0ae49ca
2 changed files with 21 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
moneymgr_backend/src/services/movements_service.rs
View File

@ -21,7 +21,11 @@ pub struct UpdateMovementQuery {
}
impl UpdateMovementQuery {
pub async fn check_error(&self, user_id: UserID) -> anyhow::Result<Option<&'static str>> {
pub async fn check_error(
&self,
user_id: UserID,
ref_movement: Option<MovementID>,
) -> anyhow::Result<Option<&'static str>> {
let constraints = ServerConstraints::default();
// Check movement label
@ -30,7 +34,9 @@ impl UpdateMovementQuery {
}
// Check the account
let account = accounts_service::get_by_id(self.account_id).await?;
let Ok(account) = accounts_service::get_by_id(self.account_id).await else {
return Ok(Some("The specified account does not exists!"));
};
if account.user_id() != user_id {
return Ok(Some("The user does not own the account!"));
}
@ -45,13 +51,15 @@ impl UpdateMovementQuery {
}
// Check for conflict with other movements
if get_by_account_label_amount_time(self.account_id, &self.label, self.amount, self.time)
.await
.is_ok()
if let Ok(movement) =
get_by_account_label_amount_time(self.account_id, &self.label, self.amount, self.time)
.await
{
return Ok(Some(
"A movement taken at the same time with the same label and the same amount already exists!",
));
if Some(movement.id()) != ref_movement {
return Ok(Some(
"A movement taken at the same time with the same label and the same amount already exists!",
));
}
}
Ok(None)