WIP ESLint fixes

This commit is contained in:
2025-03-28 11:35:51 +01:00
parent 4b9df95721
commit 9a905e83f7
40 changed files with 92 additions and 91 deletions

View File

@ -67,7 +67,7 @@ export function AsyncWidget(p: {
<Button onClick={load}>Try again</Button>
{p.errAdditionalElement && p.errAdditionalElement()}
{p.errAdditionalElement?.()}
</Box>
)
);

View File

@ -32,13 +32,13 @@ export function ConfigImportExportButtons(p: {
// Wait for a file to be chosen
await new Promise((res, _rej) =>
fileEl.addEventListener("change", () => res(null))
{ fileEl.addEventListener("change", () => { res(null); }); }
);
if ((fileEl.files?.length ?? 0) === 0) return null;
// Import conf
let file = fileEl.files![0];
const file = fileEl.files![0];
const content = await file.text();
p.importConf?.(JSON.parse(content));
} catch (e) {

View File

@ -24,7 +24,7 @@ export function TabsWidget<E>(p: {
<Box sx={{ borderBottom: 1, borderColor: "divider" }}>
<Tabs
value={currTabIndex}
onChange={(_ev, newVal) => updateActiveTab(newVal)}
onChange={(_ev, newVal) => { updateActiveTab(newVal); }}
>
{activeOptions.map((o, index) => (
<Tab key={index} label={o.label} style={{ color: o.color }} />

View File

@ -17,7 +17,7 @@ export function CheckboxInput(p: {
<Checkbox
disabled={!p.editable}
checked={p.checked}
onChange={(e) => p.onValueChange(e.target.checked)}
onChange={(e) => { p.onValueChange(e.target.checked); }}
/>
}
label={p.label}

View File

@ -44,7 +44,7 @@ export function IPInputWithMask(p: {
return;
}
const split = v?.split("/");
const split = v.split("/");
const ip =
p.version === 4 ? sanitizeIpV4(split[0]) : sanitizeIpV6(split[0]);
let mask = undefined;
@ -69,7 +69,7 @@ export function IPInputWithMask(p: {
function sanitizeIpV4(s: string | undefined): string | undefined {
if (s === "" || s === undefined) return s;
let split = s.split(".");
const split = s.split(".");
if (split.length > 4) split.splice(4);
let needAnotherIteration = false;
@ -106,7 +106,7 @@ function sanitizeIpV6(s: string | undefined): string | undefined {
const num = parseInt(e, 16);
if (isNaN(num)) return "0";
let s = num.toString(16);
const s = num.toString(16);
if (num > 0xffff) {
needAnotherIteration = true;
return s.slice(0, 4) + ":" + s.slice(4);

View File

@ -32,7 +32,7 @@ function sanitizeMacAddress(s: string | undefined): string | undefined {
const num = parseInt(e, 16);
if (isNaN(num)) return "0";
let s = num.toString(16).padStart(2, "0");
const s = num.toString(16).padStart(2, "0");
if (num > 0xff) {
needAnotherIteration = true;
return s.slice(0, 2) + ":" + s.slice(2);

View File

@ -12,7 +12,7 @@ export function NWFConnStateInput(p: {
label="Connection state"
value={p.value}
onValueChange={(s) => {
p.onChange?.(s as any);
p.onChange(s as any);
}}
options={[
{ label: "None", value: undefined },

View File

@ -13,7 +13,7 @@ export function NWFilterPriorityInput(p: {
value={p.value?.toString()}
type="number"
onValueChange={(v) => {
p.onChange?.(v && v !== "" ? Number(v) : undefined);
p.onChange(v && v !== "" ? Number(v) : undefined);
}}
size={ServerApi.Config.constraints.nwfilter_priority}
helperText="A lower priority value is accessed before one with a higher value"

View File

@ -66,9 +66,9 @@ export function NWFilterRules(p: {
deleteRule(n);
}}
onGoDown={
n < p.rules.length - 1 ? () => swapRules(n, n + 1) : undefined
n < p.rules.length - 1 ? () => { swapRules(n, n + 1); } : undefined
}
onGoUp={n > 0 ? () => swapRules(n, n - 1) : undefined}
onGoUp={n > 0 ? () => { swapRules(n, n - 1); } : undefined}
{...p}
/>
))}
@ -153,7 +153,7 @@ function NWRuleEdit(p: {
editable={p.editable}
onChange={p.onChange}
selector={s}
onDelete={() => deleteSelector(n)}
onDelete={() => { deleteSelector(n); }}
/>
))}
</CardContent>

View File

@ -130,7 +130,7 @@ function HostReservationWidget(p: {
value={p.host.mac}
onValueChange={(v) => {
p.host.mac = v!;
p.onChange?.();
p.onChange();
}}
/>
)}
@ -142,7 +142,7 @@ function HostReservationWidget(p: {
value={p.host.ip}
onValueChange={(v) => {
p.host.ip = v!;
p.onChange?.();
p.onChange();
}}
/>
</div>

View File

@ -12,7 +12,7 @@ export function PortInput(p: {
value={p.value?.toString() ?? ""}
type="number"
onValueChange={(v) => {
p.onChange?.(sanitizePort(v));
p.onChange(sanitizePort(v));
}}
checkValue={(v) => Number(v) <= 65535}
/>

View File

@ -24,7 +24,7 @@ export function RadioGroupInput(p: {
<RadioGroup
row
value={p.value}
onChange={(_ev, v) => p.onValueChange?.(v)}
onChange={(_ev, v) => { p.onValueChange(v); }}
>
{p.options.map((o) => (
<FormControlLabel

View File

@ -33,7 +33,7 @@ export function SelectInput(p: {
<Select
value={p.value ?? ""}
label={p.label}
onChange={(e) => p.onValueChange(e.target.value)}
onChange={(e) => { p.onValueChange(e.target.value); }}
>
{p.options.map((e) => (
<MenuItem

View File

@ -260,7 +260,7 @@ function IPSection(p: {
const confirm = useConfirm();
const toggleNetwork = async () => {
if (!!p.config) {
if (p.config) {
if (
!(await confirm(
`Do you really want to disable IPv${p.version} on this network? Specific configuration will be deleted!`
@ -268,11 +268,11 @@ function IPSection(p: {
)
return;
p.onChange?.(undefined);
p.onChange(undefined);
return;
}
p.onChange?.({
p.onChange({
bridge_address: p.version === 4 ? "192.168.1.1" : "fd00::1",
prefix: p.version === 4 ? 24 : 8,
});
@ -298,7 +298,7 @@ function IPSection(p: {
p.config!.dhcp = undefined;
}
p.onChange?.(p.config);
p.onChange(p.config);
};
const toggleNAT = async (v: boolean) => {
@ -315,7 +315,7 @@ function IPSection(p: {
p.config!.nat = undefined;
}
p.onChange?.(p.config);
p.onChange(p.config);
};
if (!p.config && !p.editable) return <></>;
@ -338,10 +338,10 @@ function IPSection(p: {
editable={p.editable}
label="Bridge address"
version={p.version}
value={p.config?.bridge_address}
value={p.config.bridge_address}
onValueChange={(v) => {
p.config!.bridge_address = v ?? "";
p.onChange?.(p.config);
p.onChange(p.config);
}}
/>
@ -352,7 +352,7 @@ function IPSection(p: {
type="number"
onValueChange={(v) => {
p.config!.prefix = Number(v);
p.onChange?.(p.config);
p.onChange(p.config);
}}
size={
p.version === 4 ? { min: 0, max: 32 } : { min: 0, max: 128 }
@ -407,7 +407,7 @@ function IPSection(p: {
dhcp={p.config.dhcp}
onChange={(d) => {
p.config!.dhcp = d;
p.onChange?.(p.config);
p.onChange(p.config);
}}
/>
</EditSection>
@ -431,7 +431,7 @@ function IPSection(p: {
nat={p.config.nat}
onChange={(n) => {
p.config!.nat = n;
p.onChange?.(p.config);
p.onChange(p.config);
}}
/>
)}

View File

@ -29,13 +29,13 @@ export function NetworkStatusWidget(p: {
}
};
const changedAction = () => setState(undefined);
const changedAction = () => { setState(undefined); };
React.useEffect(() => {
refresh();
const i = setInterval(() => refresh(), 3000);
return () => clearInterval(i);
return () => { clearInterval(i); };
});
if (state === undefined)

View File

@ -95,7 +95,7 @@ export function TokenRawRightsEditor(p: {
</TableCell>
{p.editable && (
<TableCell style={{ width: "100px" }}>
<IconButton onClick={() => deleteRule(num)}>
<IconButton onClick={() => { deleteRule(num); }}>
<Tooltip title="Remove the rule">
<DeleteIcon />
</Tooltip>

View File

@ -576,7 +576,7 @@ export function TokenRightsEditor(p: {
right={{ verb: "GET", path: `/api/nwfilter/${v.uuid}` }}
parent={{ verb: "GET", path: "/api/nwfilter/*" }}
/>
{ServerApi.Config.builtin_nwfilter_rules.includes(v.name!) ? (
{ServerApi.Config.builtin_nwfilter_rules.includes(v.name) ? (
<TableCell></TableCell>
) : (
<CellRight
@ -585,7 +585,7 @@ export function TokenRightsEditor(p: {
parent={{ verb: "PUT", path: "/api/nwfilter/*" }}
/>
)}
{ServerApi.Config.builtin_nwfilter_rules.includes(v.name!) ? (
{ServerApi.Config.builtin_nwfilter_rules.includes(v.name) ? (
<TableCell></TableCell>
) : (
<CellRight
@ -767,7 +767,7 @@ function RouteRight(p: RightOpts): React.ReactElement {
const parentActivated =
!!p.parent &&
p.token.rights.findIndex(
(r) => r.verb === p.parent?.verb && r.path === p.parent?.path
(r) => r.verb === p.parent?.verb && r.path === p.parent.path
) !== -1;
const toggle = (a: boolean) => {
@ -804,7 +804,7 @@ function RouteRight(p: RightOpts): React.ReactElement {
<Checkbox
checked={activated || parentActivated}
disabled={!p.editable || parentActivated}
onChange={(_e, a) => toggle(a)}
onChange={(_e, a) => { toggle(a); }}
/>
}
label={p.label}
@ -814,7 +814,7 @@ function RouteRight(p: RightOpts): React.ReactElement {
<Checkbox
checked={activated || parentActivated}
disabled={!p.editable || parentActivated}
onChange={(_e, a) => toggle(a)}
onChange={(_e, a) => { toggle(a); }}
/>
</span>
)}

View File

@ -222,7 +222,7 @@ function VMDetailsTabGeneral(p: DetailsInnerProps): React.ReactElement {
: "Add a new group instead of using existing one"
}
>
<IconButton onClick={() => setAddGroup(!addGroup)}>
<IconButton onClick={() => { setAddGroup(!addGroup); }}>
{addGroup ? <ListIcon /> : <AddIcon />}
</IconButton>
</Tooltip>

View File

@ -31,13 +31,13 @@ export function VMStatusWidget(p: {
}
};
const changedAction = () => setState(undefined);
const changedAction = () => { setState(undefined); };
React.useEffect(() => {
refresh();
const i = setInterval(() => refresh(), 3000);
return () => clearInterval(i);
return () => { clearInterval(i); };
});
if (state === undefined)