From a1439689dd9ec0a967c27340128a2e25503965c8 Mon Sep 17 00:00:00 2001
From: Pierre HUBERT <pierre.git@communiquons.org>
Date: Mon, 9 Jun 2025 18:00:23 +0200
Subject: [PATCH] Can resize existing disks

---
 virtweb_frontend/src/api/VMApi.ts             |   1 +
 .../src/widgets/forms/DiskSizeInput.tsx       |  24 ++++
 .../src/widgets/forms/VMDisksList.tsx         | 130 +++++++++++-------
 3 files changed, 109 insertions(+), 46 deletions(-)
 create mode 100644 virtweb_frontend/src/widgets/forms/DiskSizeInput.tsx

diff --git a/virtweb_frontend/src/api/VMApi.ts b/virtweb_frontend/src/api/VMApi.ts
index 5df788f..44c4647 100644
--- a/virtweb_frontend/src/api/VMApi.ts
+++ b/virtweb_frontend/src/api/VMApi.ts
@@ -36,6 +36,7 @@ export interface BaseFileVMDisk {
 
   // application attributes
   new?: boolean;
+  originalSize?: number;
   deleteType?: "keepfile" | "deletefile";
 }
 
diff --git a/virtweb_frontend/src/widgets/forms/DiskSizeInput.tsx b/virtweb_frontend/src/widgets/forms/DiskSizeInput.tsx
new file mode 100644
index 0000000..d9ec6de
--- /dev/null
+++ b/virtweb_frontend/src/widgets/forms/DiskSizeInput.tsx
@@ -0,0 +1,24 @@
+import { ServerApi } from "../../api/ServerApi";
+import { TextInput } from "./TextInput";
+
+export function DiskSizeInput(p: {
+  label?: string;
+  value: number;
+  onChange: (size: number) => void;
+}): React.ReactElement {
+  return (
+    <TextInput
+      editable={true}
+      label={p.label ?? "Disk size (GB)"}
+      size={{
+        min: ServerApi.Config.constraints.disk_size.min / (1000 * 1000 * 1000),
+        max: ServerApi.Config.constraints.disk_size.max / (1000 * 1000 * 1000),
+      }}
+      value={(p.value / (1000 * 1000 * 1000)).toString()}
+      onValueChange={(v) => {
+        p.onChange?.(Number(v ?? "0") * 1000 * 1000 * 1000);
+      }}
+      type="number"
+    />
+  );
+}
diff --git a/virtweb_frontend/src/widgets/forms/VMDisksList.tsx b/virtweb_frontend/src/widgets/forms/VMDisksList.tsx
index 4b69923..d3c121b 100644
--- a/virtweb_frontend/src/widgets/forms/VMDisksList.tsx
+++ b/virtweb_frontend/src/widgets/forms/VMDisksList.tsx
@@ -1,5 +1,6 @@
 import { mdiHarddiskPlus } from "@mdi/js";
 import Icon from "@mdi/react";
+import ExpandIcon from "@mui/icons-material/Expand";
 import CheckCircleIcon from "@mui/icons-material/CheckCircle";
 import DeleteIcon from "@mui/icons-material/Delete";
 import { Button, IconButton, Paper, Tooltip, Typography } from "@mui/material";
@@ -15,6 +16,7 @@ import { DiskBusSelect } from "./DiskBusSelect";
 import { DiskImageSelect } from "./DiskImageSelect";
 import { SelectInput } from "./SelectInput";
 import { TextInput } from "./TextInput";
+import { DiskSizeInput } from "./DiskSizeInput";
 
 export function VMDisksList(p: {
   vm: VMInfo;
@@ -99,6 +101,19 @@ function DiskInfo(p: {
   diskImagesList: DiskImage[];
 }): React.ReactElement {
   const confirm = useConfirm();
+
+  const expandDisk = () => {
+    if (p.disk.resize === true) {
+      p.disk.resize = false;
+      p.disk.size = p.disk.originalSize!;
+    } else {
+      p.disk.resize = true;
+      p.disk.originalSize = p.disk.size!;
+    }
+
+    p.onChange?.();
+  };
+
   const deleteDisk = async () => {
     if (p.disk.deleteType) {
       p.disk.deleteType = undefined;
@@ -121,42 +136,74 @@ function DiskInfo(p: {
 
   if (!p.editable || !p.disk.new)
     return (
-      <VMDiskFileWidget
-        {...p}
-        secondaryAction={
-          <>
-            {p.editable && (
-              <IconButton
-                edge="end"
-                aria-label="delete disk"
-                onClick={deleteDisk}
-              >
-                {p.disk.deleteType ? (
-                  <Tooltip title="Cancel disk removal">
-                    <CheckCircleIcon />
-                  </Tooltip>
-                ) : (
-                  <Tooltip title="Remove disk">
-                    <DeleteIcon />
-                  </Tooltip>
-                )}
-              </IconButton>
-            )}
-
-            {p.canBackup && (
-              <Tooltip title="Backup this disk">
+      <>
+        <VMDiskFileWidget
+          {...p}
+          secondaryAction={
+            <>
+              {p.editable && (
                 <IconButton
-                  onClick={() => {
-                    p.onRequestBackup(p.disk);
-                  }}
+                  edge="end"
+                  aria-label="expand disk"
+                  onClick={expandDisk}
                 >
-                  <Icon path={mdiHarddiskPlus} size={1} />
+                  {p.disk.resize === true ? (
+                    <Tooltip title="Cancel disk expansion">
+                      <ExpandIcon color="error" />
+                    </Tooltip>
+                  ) : (
+                    <Tooltip title="Increase disk size">
+                      <ExpandIcon />
+                    </Tooltip>
+                  )}
                 </IconButton>
-              </Tooltip>
-            )}
-          </>
-        }
-      />
+              )}
+
+              {p.editable && (
+                <IconButton
+                  edge="end"
+                  aria-label="delete disk"
+                  onClick={deleteDisk}
+                >
+                  {p.disk.deleteType ? (
+                    <Tooltip title="Cancel disk removal">
+                      <CheckCircleIcon />
+                    </Tooltip>
+                  ) : (
+                    <Tooltip title="Remove disk">
+                      <DeleteIcon />
+                    </Tooltip>
+                  )}
+                </IconButton>
+              )}
+
+              {p.canBackup && (
+                <Tooltip title="Backup this disk">
+                  <IconButton
+                    onClick={() => {
+                      p.onRequestBackup(p.disk);
+                    }}
+                  >
+                    <Icon path={mdiHarddiskPlus} size={1} />
+                  </IconButton>
+                </Tooltip>
+              )}
+            </>
+          }
+        />
+
+        {/* New disk size*/}
+        {p.disk.resize && (
+          <DiskSizeInput
+            label="New disk size (GB)"
+            value={p.disk.size}
+            onChange={(v) => {
+              p.disk.size = v;
+              p.onChange?.();
+            }}
+          />
+        )}
+      </>
     );
 
   return (
@@ -233,21 +280,12 @@ function DiskInfo(p: {
 
       {/* Disk size */}
       {(!p.disk.from_image || p.disk.resize === true) && (
-        <TextInput
-          editable={true}
-          label="Disk size (GB)"
-          size={{
-            min:
-              ServerApi.Config.constraints.disk_size.min / (1000 * 1000 * 1000),
-            max:
-              ServerApi.Config.constraints.disk_size.max / (1000 * 1000 * 1000),
-          }}
-          value={(p.disk.size / (1000 * 1000 * 1000)).toString()}
-          onValueChange={(v) => {
-            p.disk.size = Number(v ?? "0") * 1000 * 1000 * 1000;
+        <DiskSizeInput
+          value={p.disk.size}
+          onChange={(v) => {
+            p.disk.size = v;
             p.onChange?.();
           }}
-          type="number"
         />
       )}